[#1701] Changed User.get_full_name() to prefer .display_name over .first_name #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-sigma
requested changes
Sep 20, 2023
src/open_inwoner/accounts/models.py
Outdated
| @@ -313,7 +313,8 @@ def seed(self): | |||
| return self._seed | |||
|
|
|||
| def get_full_name(self): | |||
| parts = (self.first_name, self.infix, self.last_name) | |||
| first_name = self.display_name or self.first_name | |||
There was a problem hiding this comment.
The display_name field uses CharFieldValidator, which allows strings containing only spaces. We probably don't want to prefer a display_name containing only space. We could should strip() and use isspace() to check for that or change the validator on the model field to prevent this from arising in the first place.
There was a problem hiding this comment.
Ugh that's not great. It is unlikely we have only-spaces values because form-fields use .strip() by default but I modified the code to be safe.
pi-sigma
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ability to change this centrally shows why DRY code (like a method) is preferred over spreading ad-hoc code.