[#1735] Fix cookiebanner position for mobile devices #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #764 +/- ##
========================================
Coverage 93.58% 93.58%
========================================
Files 697 697
Lines 24595 24595
========================================
Hits 23016 23016
Misses 1579 1579 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alextreme
approved these changes
Sep 17, 2023
|
@alextreme Yes this one is a bit difficult to check and I'm not sure if Browserstack is truly 100% native - I may need to buy an android so I can use NGROK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue only occurs on mobile devices (margins on desktop are not affected by scroll or size of URL bar)
PR can only be reviewed on mobile devices, so either use NGROK or use Browserstack.
issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/1735