[#1672] Reworked auth backends, contacts to support non-unique (digid) emails #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bartvaderkin
force-pushed
the
feature/1672-email-unique-modified
branch
from
838571e
to
3f90673
Compare
Bartvaderkin
changed the title
Bartvaderkin
changed the title
…tive_duplicate_email
Codecov Report
@@ Coverage Diff @@
## feature/1672-email-unique #760 +/- ##
=============================================================
- Coverage 96.36% 96.33% -0.04%
=============================================================
Files 693 694 +1
Lines 24538 24540 +2
=============================================================
- Hits 23647 23641 -6
- Misses 891 899 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more 📢 Have feedback on the report? Share it here. |
alextreme
reviewed
Sep 8, 2023
alextreme
reviewed
Sep 8, 2023
alextreme
reviewed
Sep 8, 2023
| @@ -33,6 +33,8 @@ def get_by_rsin(self, rsin): | |||
| return self.get_queryset().get(rsin=rsin) | |||
|
|
|||
| def eherkenning_create(self, rsin, **kwargs): | |||
| raise NotImplementedError("old code, please verify before use") | |||
| # TODO what is this @rsin.com email hostname? @example.org is bad enough but this actually exists | |||
There was a problem hiding this comment.
We don't use eHerkenning at the moment, but we will later this year for companies. Not within scope atm
alextreme
reviewed
Sep 8, 2023
| @@ -219,44 +222,86 @@ class Meta: | |||
| verbose_name = _("User") | |||
| verbose_name_plural = _("Users") | |||
|
|
|||
| constraints = [ | |||
There was a problem hiding this comment.
Feel free to continue with this next week. I like these more flexible unique constraints, having them depending on the login time makes sense in my eyes.
alextreme
reviewed
Sep 8, 2023
|
|
||
| @classmethod | ||
| def setUpTestData(cls): | ||
| cls.msg_dupes = _("This email is already taken.") | ||
| cls.msg_inactive = _("This account has been deactivated") | ||
|
|
||
| # TODO use factories and valid Users (eg: bsn AND LoginTypeChoices.digid) |
alextreme
reviewed
Sep 8, 2023
|
|
||
| @requests_mock.Mocker() | ||
| def test_digid_user_non_digid_duplicate_fail(self, m): | ||
| # TODO |
alextreme
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #736