Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1661] Changed footer to use static placeholders #731

Merged
merged 4 commits into from
Sep 7, 2023

Conversation

Bartvaderkin
Copy link
Contributor

@Bartvaderkin Bartvaderkin commented Aug 11, 2023

No description provided.

@Bartvaderkin Bartvaderkin force-pushed the feature/1661-static-placeholder branch from 5d9c2dd to bf0bd5d Compare August 11, 2023 10:44
@Bartvaderkin Bartvaderkin force-pushed the feature/1661-static-placeholder branch from bf0bd5d to 3682d82 Compare August 21, 2023 09:02
@Bartvaderkin Bartvaderkin marked this pull request as ready for review August 21, 2023 10:16
@Bartvaderkin Bartvaderkin marked this pull request as draft August 21, 2023 12:24
@codecov-commenter
Copy link

Codecov Report

Merging #731 (9e661bf) into develop (9190e39) will increase coverage by 0.00%.
Report is 2 commits behind head on develop.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #731   +/-   ##
========================================
  Coverage    96.27%   96.28%           
========================================
  Files          674      676    +2     
  Lines        24007    24024   +17     
========================================
+ Hits         23113    23131   +18     
+ Misses         894      893    -1     
Files Changed Coverage Δ
src/open_inwoner/configurations/admin.py 100.00% <ø> (ø)
src/open_inwoner/configurations/models.py 97.65% <ø> (-0.11%) ⬇️
...c/open_inwoner/openklant/tests/test_contactform.py 100.00% <ø> (ø)
src/open_inwoner/utils/context_processors.py 90.90% <ø> (ø)
src/open_inwoner/cms/footer/cms_plugins.py 100.00% <100.00%> (ø)
src/open_inwoner/cms/footer/tests/test_plugin.py 100.00% <100.00%> (ø)
src/open_inwoner/conf/base.py 95.58% <100.00%> (+0.02%) ⬆️
...nfigurations/migrations/0049_auto_20230821_1523.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Bartvaderkin Bartvaderkin marked this pull request as ready for review August 22, 2023 12:56
@alextreme alextreme merged commit 0f01f2b into develop Sep 7, 2023
10 checks passed
@alextreme alextreme deleted the feature/1661-static-placeholder branch September 7, 2023 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants