[#1645] improve design of product page #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-sigma
force-pushed
the
feature/1645-product-page-design
branch
2 times, most recently
from
511ce1e
to
0a6b460
Compare
|
A test that verifies that a modified button_text is shown on the product page would be appreciated. Might feel a bit simple though... |
- make cta button text configurable - remove mobile-view button from product detail template (unnecessary duplication) - break up overflowing links in text field - fix data-migration test by using appropriate models
pi-sigma
force-pushed
the
feature/1645-product-page-design
branch
from
0a6b460
to
ad6114f
Compare
Would indeed be more flexible, but I'd prefer to stick with Paul's simpler approach as making the markdown-content parsing more complicated may be tricky. I'm not sure if having multiple buttons with different names would be necessary, especially as all buttons point to the same URL/form... |
Bartvaderkin
approved these changes
Aug 21, 2023
|
Have made this PR ready-for-review, but allowing @pi-sigma to double-check just in case it was on Draft for a reason |
|
@alextreme Good to go, I forgot to mark it for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga: #1645