Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1566] Add email registration to case detail contact form #700

Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Jun 26, 2023

FYI, currently we have the contact form in the case detail view but we only support sending a question via the api configuration. With this task we want to add the email configuration as well.

It will be easier to review this if you take a look at https://github.com/maykinmedia/open-inwoner/blob/develop/src/open_inwoner/openklant/views/contactform.py, where Bart had already implemented this for the basic contact form page.

@vaszig vaszig force-pushed the feature/1566-add-email-registration-to-case-detail-page branch from 30a1479 to 1ce4887 Compare June 26, 2023 11:54
@vaszig vaszig force-pushed the feature/1566-add-email-registration-to-case-detail-page branch from 1ce4887 to 65dac2a Compare June 26, 2023 14:07
@codecov-commenter
Copy link

Codecov Report

Merging #700 (65dac2a) into develop (087347a) will increase coverage by 0.02%.
The diff coverage is 96.45%.

@@             Coverage Diff             @@
##           develop     #700      +/-   ##
===========================================
+ Coverage    96.17%   96.20%   +0.02%     
===========================================
  Files          636      639       +3     
  Lines        22683    22887     +204     
===========================================
+ Hits         21816    22019     +203     
- Misses         867      868       +1     
Impacted Files Coverage Δ
src/open_inwoner/configurations/admin.py 100.00% <ø> (ø)
src/open_inwoner/utils/tests/helpers.py 89.16% <66.66%> (-1.83%) ⬇️
src/open_inwoner/cms/cases/views/status.py 88.84% <83.87%> (-0.35%) ⬇️
src/open_inwoner/cms/cases/tests/test_htmx.py 57.93% <87.50%> (+0.21%) ⬆️
src/open_inwoner/utils/tests/playwright.py 76.81% <91.66%> (-1.92%) ⬇️
src/open_inwoner/accounts/forms.py 97.80% <100.00%> (+0.04%) ⬆️
...c/open_inwoner/accounts/tests/test_action_views.py 88.78% <100.00%> (ø)
src/open_inwoner/accounts/tests/test_inbox_page.py 94.94% <100.00%> (-0.03%) ⬇️
src/open_inwoner/accounts/tests/test_logging.py 100.00% <100.00%> (ø)
.../open_inwoner/accounts/tests/test_profile_views.py 100.00% <100.00%> (ø)
... and 8 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, this is in line with how the general contactform works

Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good (the suggested change is cosmetic).

src/open_inwoner/cms/cases/views/status.py Show resolved Hide resolved
@pi-sigma pi-sigma merged commit fd270fd into develop Jun 27, 2023
@pi-sigma pi-sigma deleted the feature/1566-add-email-registration-to-case-detail-page branch June 27, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants