-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1437 #1457] Enhanced contact-form to create/update Klant, or fallback to appending contact info #664
Conversation
…ck to appending contact info
6bac99d
to
b3ef4d9
Compare
@vaszig I marked as ready for review as the main commit was green and I only appended some comment cleanup |
Codecov Report
@@ Coverage Diff @@
## develop #664 +/- ##
===========================================
+ Coverage 96.46% 96.47% +0.01%
===========================================
Files 621 621
Lines 21908 22069 +161
===========================================
+ Hits 21133 21291 +158
- Misses 775 778 +3
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments but generally I don't find something weird.
Discussed with @vaszig and we would like the comments to be resolved (he approved but he still had remarks open) |
@vaszig I appended answers and a commit with small fixes. |
25ee71a
to
ecfc9fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can merge it if tests pass.
No description provided.