Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1437 #1457] Enhanced contact-form to create/update Klant, or fallback to appending contact info #664

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

Bartvaderkin
Copy link
Contributor

No description provided.

@Bartvaderkin Bartvaderkin force-pushed the feature/1437-1457-contact-form-klanten branch from 6bac99d to b3ef4d9 Compare June 8, 2023 15:12
@Bartvaderkin Bartvaderkin marked this pull request as ready for review June 9, 2023 06:57
@Bartvaderkin Bartvaderkin requested a review from vaszig June 9, 2023 06:57
@Bartvaderkin
Copy link
Contributor Author

@vaszig I marked as ready for review as the main commit was green and I only appended some comment cleanup

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2023

Codecov Report

Merging #664 (ecfc9fb) into develop (ba9e76c) will increase coverage by 0.01%.
The diff coverage is 94.27%.

@@             Coverage Diff             @@
##           develop     #664      +/-   ##
===========================================
+ Coverage    96.46%   96.47%   +0.01%     
===========================================
  Files          621      621              
  Lines        21908    22069     +161     
===========================================
+ Hits         21133    21291     +158     
- Misses         775      778       +3     
Impacted Files Coverage Δ
src/open_inwoner/openklant/wrap.py 72.35% <57.14%> (+0.53%) ⬆️
src/open_inwoner/openklant/views/contactform.py 93.68% <89.47%> (-3.15%) ⬇️
src/open_inwoner/utils/tests/helpers.py 90.82% <92.30%> (+<0.01%) ⬆️
src/open_inwoner/openklant/forms.py 100.00% <100.00%> (ø)
src/open_inwoner/openklant/models.py 100.00% <100.00%> (ø)
src/open_inwoner/openklant/tests/data.py 100.00% <100.00%> (ø)
...c/open_inwoner/openklant/tests/test_contactform.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments but generally I don't find something weird.

src/open_inwoner/openklant/views/contactform.py Outdated Show resolved Hide resolved
src/open_inwoner/openklant/views/contactform.py Outdated Show resolved Hide resolved
src/open_inwoner/openklant/views/contactform.py Outdated Show resolved Hide resolved
src/open_inwoner/utils/tests/helpers.py Show resolved Hide resolved
@alextreme
Copy link
Member

Discussed with @vaszig and we would like the comments to be resolved (he approved but he still had remarks open)

@Bartvaderkin
Copy link
Contributor Author

@vaszig I appended answers and a commit with small fixes.

@Bartvaderkin Bartvaderkin requested a review from vaszig June 13, 2023 10:22
@Bartvaderkin Bartvaderkin force-pushed the feature/1437-1457-contact-form-klanten branch from 25ee71a to ecfc9fb Compare June 13, 2023 10:37
Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge it if tests pass.

@alextreme alextreme merged commit c7111fb into develop Jun 13, 2023
@alextreme alextreme deleted the feature/1437-1457-contact-form-klanten branch June 13, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants