Skip to content

[#1466] Make sharing files via Mijn Berichten configurable #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented May 31, 2023

No description provided.

@vaszig vaszig requested a review from Bartvaderkin May 31, 2023 13:56
@Bartvaderkin Bartvaderkin changed the title [1466] Make sharing files via Mijn Berichten configurable [#1466] Make sharing files via Mijn Berichten configurable Jun 1, 2023
@Bartvaderkin
Copy link
Contributor

Oh heh @vaszig I noticed the commit message is missing the #-hash

@vaszig vaszig force-pushed the feature/1466-make-sharing-files-via-messages-configurable branch 2 times, most recently from 70a43bc to 48998e7 Compare June 2, 2023 09:10
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #639 (a676c1f) into develop (5f78ccb) will increase coverage by 0.01%.
The diff coverage is 97.65%.

@@             Coverage Diff             @@
##           develop     #639      +/-   ##
===========================================
+ Coverage    96.46%   96.47%   +0.01%     
===========================================
  Files          612      613       +1     
  Lines        21172    21276     +104     
===========================================
+ Hits         20424    20527     +103     
- Misses         748      749       +1     
Impacted Files Coverage Δ
src/open_inwoner/plans/tests/test_views.py 100.00% <ø> (ø)
src/open_inwoner/accounts/views/inbox.py 98.64% <88.88%> (-1.36%) ⬇️
src/open_inwoner/utils/tests/helpers.py 90.81% <90.00%> (-0.10%) ⬇️
src/open_inwoner/accounts/forms.py 98.07% <100.00%> (+0.04%) ⬆️
src/open_inwoner/accounts/tests/test_admin.py 100.00% <100.00%> (ø)
.../open_inwoner/accounts/tests/test_contact_views.py 100.00% <100.00%> (ø)
src/open_inwoner/accounts/tests/test_inbox_page.py 94.97% <100.00%> (+1.40%) ⬆️
...en_inwoner/accounts/tests/test_inbox_start_page.py 100.00% <100.00%> (ø)
.../open_inwoner/accounts/tests/test_profile_views.py 100.00% <100.00%> (ø)
src/open_inwoner/configurations/admin.py 100.00% <100.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vaszig vaszig force-pushed the feature/1466-make-sharing-files-via-messages-configurable branch from 48998e7 to a676c1f Compare June 2, 2023 10:04
@alextreme alextreme merged commit 56b7920 into develop Jun 2, 2023
@alextreme alextreme deleted the feature/1466-make-sharing-files-via-messages-configurable branch June 2, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants