Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1416] Add mijn vragen to profile apphook config #629

Merged
merged 2 commits into from
May 23, 2023

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented May 22, 2023

No description provided.

@vaszig vaszig requested a review from Bartvaderkin May 22, 2023 14:56
@codecov-commenter
Copy link

Codecov Report

Merging #629 (b3c14ea) into develop (e6c417b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #629   +/-   ##
========================================
  Coverage    96.51%   96.51%           
========================================
  Files          600      601    +1     
  Lines        20650    20689   +39     
========================================
+ Hits         19930    19969   +39     
  Misses         720      720           
Impacted Files Coverage Δ
src/open_inwoner/cms/profile/admin.py 85.71% <ø> (ø)
src/open_inwoner/cms/profile/cms_appconfig.py 100.00% <100.00%> (ø)
...file/migrations/0002_profileconfig_my_questions.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we call this "questions" instead of "my_questions"?

@vaszig vaszig requested a review from Bartvaderkin May 23, 2023 10:08
@alextreme alextreme merged commit f695ae1 into develop May 23, 2023
@alextreme alextreme deleted the feature/1416-add-mijn-vragen-option-to-profile branch May 23, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants