Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1442] Fix django-admin-index fixture #615

Merged
merged 2 commits into from
May 12, 2023

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented May 11, 2023

No description provided.

@vaszig vaszig requested a review from Bartvaderkin May 11, 2023 13:58
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in formatting makes it hard to see actual changes in the diff.

Did you generate this with the generate_admin_index_fixture.sh script from the bin folder?

If I look at the GIT history I see some other changes that look a bit suspicious.

@vaszig
Copy link
Contributor Author

vaszig commented May 12, 2023

The change in formatting makes it hard to see actual changes in the diff.

Did you generate this with the generate_admin_index_fixture.sh script from the bin folder?

If I look at the GIT history I see some other changes that look a bit suspicious.

@Bartvaderkin I did this in this way but black formatted the json file, so I reverted it and it works as expected

@Bartvaderkin
Copy link
Contributor

@vaszig I don't think you're supposed to black json :D

Check what your using as githook or script so it filters on python files.

@codecov-commenter
Copy link

Codecov Report

Merging #615 (5b4f33b) into develop (325d753) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #615      +/-   ##
===========================================
+ Coverage    96.39%   96.41%   +0.02%     
===========================================
  Files          574      578       +4     
  Lines        19811    19929     +118     
===========================================
+ Hits         19096    19214     +118     
  Misses         715      715              

see 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alextreme alextreme merged commit 5f8581f into develop May 12, 2023
@alextreme alextreme deleted the issue/1442-dj-admin-index-fixture branch May 12, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants