-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1316] Add title-description to banner plugin #610
[#1316] Add title-description to banner plugin #610
Conversation
0c60c62
to
d26e669
Compare
Codecov Report
@@ Coverage Diff @@
## develop #610 +/- ##
==========================================
Coverage ? 96.41%
==========================================
Files ? 579
Lines ? 19951
Branches ? 0
==========================================
Hits ? 19235
Misses ? 716
Partials ? 0
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
name = models.CharField( | ||
_("Name"), | ||
max_length=250, | ||
help_text=_("The name of the image (this will not be shown on the page)"), | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need a name-field if we're not showing it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking that we do not have any required fields, so maybe I should remove name and make image a required field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed with Bart, name fields are not useful. Image and title will be the required fields for the two models (BannerImage
and BannerText
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reasoning why I didn't request to remove 'name' is that I often see plugins with an (internal) name which is only used for plugin.str , this to make the name visible in the CMS when editting the page.
This is mostly used for CMS pages with long lists of plugins, so I agree that the benefit for only the bannerplugin is quite limited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this text area is really only visible when logged in? Becasue when you're logged out, there is a different 'welkom' area visible that is still there and cannot be removed by the user and is configarable from the Admin.
So when am logged out i still see the 'Koptekst homepage' area on Home because that is a required field - i am not sure if that one needs to be required and visible still - what do you think @alextreme ?
d26e669
to
e474442
Compare
This was discussed with @vaszig as a workable intermediate solution (populating the anonymous page via the Algemene Configuratie, and the logged-in homepage via the CMS). But I agree it isn't ideal, I would like to have the anonymous homepage configurable via the CMS too but that would be a next step. |
e474442
to
48b174a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last week I started adding tests for the plugins, for example (some others as well):
We should do that for all plugins.
Discussed with Alex as well, this does not make sense to be combined in one plugin. We need the title and description to be available in another section (in the main-grid and not in the banner), so a second plugin was created for this purpose.