Skip to content

[#1394] Add banner plugin #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2023
Merged

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Apr 20, 2023

No description provided.

@vaszig vaszig marked this pull request as draft April 20, 2023 14:37
@vaszig vaszig force-pushed the feature/1394-django-cms-banner-plugin branch 3 times, most recently from d6eafd9 to d05952a Compare April 24, 2023 08:40
@vaszig vaszig force-pushed the feature/1394-django-cms-banner-plugin branch from d05952a to a1697ae Compare April 24, 2023 14:08
Base automatically changed from feature/django-cms to develop April 24, 2023 15:08
@codecov-commenter
Copy link

Codecov Report

Merging #592 (a1697ae) into develop (d60b7b0) will decrease coverage by 0.01%.
The diff coverage is 91.66%.

@@             Coverage Diff             @@
##           develop     #592      +/-   ##
===========================================
- Coverage    96.17%   96.16%   -0.01%     
===========================================
  Files          564      568       +4     
  Lines        19795    19831      +36     
===========================================
+ Hits         19037    19070      +33     
- Misses         758      761       +3     
Impacted Files Coverage Δ
src/open_inwoner/conf/base.py 95.37% <ø> (ø)
src/open_inwoner/configurations/models.py 97.61% <ø> (ø)
src/open_inwoner/cms/banner/cms_plugins.py 83.33% <83.33%> (ø)
src/open_inwoner/cms/banner/models.py 88.88% <88.88%> (ø)
...open_inwoner/cms/banner/migrations/0001_initial.py 100.00% <100.00%> (ø)
...s/0039_alter_siteconfiguration_hero_image_login.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vaszig vaszig marked this pull request as ready for review April 25, 2023 06:32
@vaszig vaszig requested a review from Bartvaderkin April 25, 2023 06:32
@vaszig vaszig requested a review from Bartvaderkin April 25, 2023 14:19
@alextreme alextreme merged commit 76d0d8e into develop May 1, 2023
@alextreme alextreme deleted the feature/1394-django-cms-banner-plugin branch May 1, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants