Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1308] Hide upload type from case document when only one type exists #570

Merged
merged 2 commits into from
Apr 6, 2023
Merged

[#1308] Hide upload type from case document when only one type exists #570

merged 2 commits into from
Apr 6, 2023

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Apr 4, 2023

No description provided.

@vaszig vaszig requested a review from Bartvaderkin April 4, 2023 14:40
Bartvaderkin
Bartvaderkin approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve it because it'll work and gets validated, but technically it is weird to send values through a form if we already know the value at the backend (because it is the one possible choice).

@alextreme
Copy link
Member

I agree with Bart, might need a second look later on (using 2 separate Django forms would have been neater). But okay for now.

@alextreme alextreme merged commit 644d95c into develop Apr 6, 2023
@alextreme alextreme deleted the task/1308-hide-upload-type-from-case-document-when-only-one-exists branch April 6, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bartvaderkin Bartvaderkin Bartvaderkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaszig @alextreme @Bartvaderkin