📱 [#1140] mobile: Samenwerken-listview #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #481 +/- ##
========================================
Coverage 96.46% 96.46%
========================================
Files 506 506
Lines 18300 18300
========================================
Hits 17654 17654
Misses 646 646 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Apart from the word-break-row/column fix, I've fixed a typo in translations (without generating 'compilemessages' etcetera). |
vaszig
approved these changes
Feb 21, 2023
|
I don't mind too much about also updating the translations, I tend to do this at the end of each sprint in a separate branch/PR. Having multiple branches with each their own translation changes can lead to a mess, so I propose having a "Translation Ducky" at the office to avoid this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Responsive design: fix issue where header text and button should be on top of each other, not next to each other;
see https://taiga.maykinmedia.nl/project/open-inwoner/task/1140
⚠ Note: the current structure of templates, (where the entire H1 heading is surrounding the button), makes word-breaking behave strange again sometimes (causes letter-breaking in very long words on very tiny screens).