-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1050] Implemented basic zaakinformationobject notifications #459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bartvaderkin
force-pushed
the
feature/1050-document-notification
branch
from
February 7, 2023 11:02
bb39849
to
1a6cdf4
Compare
…disable notifications
Bartvaderkin
changed the title
[#1050] Implemented basic zaakinformationobject notifications
WIP [#1050] Implemented basic zaakinformationobject notifications
Feb 7, 2023
Bartvaderkin
force-pushed
the
feature/1050-document-notification
branch
from
February 8, 2023 10:10
fde5b79
to
ddc54d9
Compare
Bartvaderkin
changed the title
WIP [#1050] Implemented basic zaakinformationobject notifications
[#1050] Implemented basic zaakinformationobject notifications
Feb 8, 2023
… issues Also regenerated the migration
Bartvaderkin
force-pushed
the
feature/1050-document-notification
branch
from
February 8, 2023 10:46
ddc54d9
to
7c10355
Compare
Codecov Report
@@ Coverage Diff @@
## develop #459 +/- ##
===========================================
+ Coverage 96.43% 96.45% +0.02%
===========================================
Files 495 502 +7
Lines 17664 18068 +404
===========================================
+ Hits 17034 17428 +394
- Misses 630 640 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vaszig
reviewed
Feb 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, I would like to test it together tomorrow.
vaszig
approved these changes
Feb 9, 2023
alextreme
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff/changes look worse then it is: