Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1050] Implemented basic zaakinformationobject notifications #459

Merged
merged 5 commits into from
Feb 9, 2023

Conversation

Bartvaderkin
Copy link
Contributor

@Bartvaderkin Bartvaderkin commented Feb 7, 2023

The diff/changes look worse then it is:

  • I had to rearrange the checks in the first part of the handler (and its tests) as they are the same for both notifications.
  • I also subdivided the notification test files in an attempt to keep file size and code volume manageable, so a lot of what seems new is actually old.

@Bartvaderkin Bartvaderkin force-pushed the feature/1050-document-notification branch from bb39849 to 1a6cdf4 Compare February 7, 2023 11:02
@Bartvaderkin Bartvaderkin changed the title [#1050] Implemented basic zaakinformationobject notifications WIP [#1050] Implemented basic zaakinformationobject notifications Feb 7, 2023
@Bartvaderkin Bartvaderkin force-pushed the feature/1050-document-notification branch from fde5b79 to ddc54d9 Compare February 8, 2023 10:10
@Bartvaderkin Bartvaderkin changed the title WIP [#1050] Implemented basic zaakinformationobject notifications [#1050] Implemented basic zaakinformationobject notifications Feb 8, 2023
@Bartvaderkin Bartvaderkin force-pushed the feature/1050-document-notification branch from ddc54d9 to 7c10355 Compare February 8, 2023 10:46
@codecov-commenter
Copy link

Codecov Report

Merging #459 (7c10355) into develop (73137fd) will increase coverage by 0.02%.
The diff coverage is 97.98%.

@@             Coverage Diff             @@
##           develop     #459      +/-   ##
===========================================
+ Coverage    96.43%   96.45%   +0.02%     
===========================================
  Files          495      502       +7     
  Lines        17664    18068     +404     
===========================================
+ Hits         17034    17428     +394     
- Misses         630      640      +10     
Impacted Files Coverage Δ
src/open_inwoner/conf/base.py 95.06% <ø> (ø)
src/open_inwoner/openzaak/documents.py 94.59% <ø> (-0.08%) ⬇️
src/open_inwoner/openzaak/cases.py 78.53% <80.00%> (+<0.01%) ⬆️
src/open_inwoner/openzaak/admin.py 90.35% <89.65%> (-0.35%) ⬇️
src/open_inwoner/openzaak/tests/factories.py 98.57% <90.00%> (-1.43%) ⬇️
src/open_inwoner/openzaak/models.py 97.82% <90.90%> (-2.18%) ⬇️
src/open_inwoner/openzaak/notifications.py 95.12% <96.00%> (-0.34%) ⬇️
src/open_inwoner/openzaak/managers.py 96.07% <96.55%> (+9.41%) ⬆️
...n_inwoner/openzaak/tests/test_notification_data.py 98.21% <98.21%> (ø)
...ner/openzaak/migrations/0011_auto_20230207_1030.py 100.00% <100.00%> (ø)
... and 13 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Bartvaderkin Bartvaderkin marked this pull request as ready for review February 8, 2023 11:35
Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, I would like to test it together tomorrow.

src/open_inwoner/openzaak/models.py Show resolved Hide resolved
src/open_inwoner/openzaak/models.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/documents.py Show resolved Hide resolved
src/open_inwoner/openzaak/managers.py Show resolved Hide resolved
src/open_inwoner/openzaak/managers.py Show resolved Hide resolved
@alextreme alextreme merged commit 3bdf500 into develop Feb 9, 2023
@alextreme alextreme deleted the feature/1050-document-notification branch February 9, 2023 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants