Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 [#1021] make entire card clickable #453

Merged
merged 1 commit into from
Feb 5, 2023

Conversation

jiromaykin
Copy link
Contributor

"As a visitor, I want to navigate through the entire product tile so that I can easily go to other pages.
Now only the image and title are clickable. Can the white part also be made clickable?"

@codecov-commenter
Copy link

Codecov Report

Merging #453 (b14e4ee) into develop (c1c0995) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop     #453      +/-   ##
===========================================
+ Coverage    96.28%   96.30%   +0.02%     
===========================================
  Files          493      493              
  Lines        17365    17365              
===========================================
+ Hits         16720    16724       +4     
+ Misses         645      641       -4     
Impacted Files Coverage Δ
src/open_inwoner/utils/views.py 79.59% <0.00%> (+8.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Voelt een beetje dubbel-op, maar prima om te proberen. Graag op testomgeving dubbelchecken qua werking, aangezien dit component op een aantal plekken terugkomt

@alextreme alextreme marked this pull request as ready for review February 5, 2023 15:22
@alextreme alextreme merged commit 6e119b1 into develop Feb 5, 2023
@alextreme alextreme deleted the fix/#1021-entire-Card-clickable branch February 5, 2023 15:22
@alextreme alextreme restored the fix/#1021-entire-Card-clickable branch February 5, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants