Skip to content

[#1047,#1063] Feature/add upload documents to the case detail page #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 31, 2023

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Jan 25, 2023

No description provided.

@vaszig vaszig changed the title [#1047-1063] Feature/add upload documents to the case detail page [#1047,#1063] Feature/add upload documents to the case detail page Jan 25, 2023
@vaszig vaszig requested a review from Bartvaderkin January 25, 2023 16:35
@codecov-commenter
Copy link

Codecov Report

Merging #439 (ab01dcd) into develop (f4b9e00) will decrease coverage by 0.09%.
The diff coverage is 90.34%.

@@             Coverage Diff             @@
##           develop     #439      +/-   ##
===========================================
- Coverage    96.35%   96.26%   -0.09%     
===========================================
  Files          473      473              
  Lines        15755    15892     +137     
===========================================
+ Hits         15180    15299     +119     
- Misses         575      593      +18     
Impacted Files Coverage Δ
src/open_inwoner/openzaak/catalog.py 52.87% <56.25%> (+0.24%) ⬆️
src/open_inwoner/accounts/forms.py 97.73% <100.00%> (+0.21%) ⬆️
src/open_inwoner/accounts/views/cases.py 97.41% <100.00%> (+0.34%) ⬆️
src/open_inwoner/openzaak/api_models.py 99.03% <100.00%> (+0.09%) ⬆️
...rc/open_inwoner/openzaak/tests/test_case_detail.py 100.00% <100.00%> (ø)
src/open_inwoner/utils/views.py 71.42% <0.00%> (-8.17%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I think the CSS needs some margin, and maybe we should alphabetically sort the extensions?

Screenshot from 2023-01-31 10-15-27

I don't like the thin field labels but it's the standard look from the components so fine.

@vaszig vaszig force-pushed the feature/1047-add-upload-to-case-detailview branch from cc190f4 to c1a3809 Compare January 31, 2023 10:21
@vaszig
Copy link
Contributor Author

vaszig commented Jan 31, 2023

Thanks for looking at the css as well!I noticed that and has been updated on the refactor branch.

@vaszig vaszig requested a review from Bartvaderkin January 31, 2023 11:41
@Bartvaderkin
Copy link
Contributor

@vaszig I approved but it looks like there are some (new) merge conflicts.

@vaszig vaszig force-pushed the feature/1047-add-upload-to-case-detailview branch from 5d42902 to 7e77c6a Compare January 31, 2023 13:28
@alextreme alextreme merged commit 2d1b020 into develop Jan 31, 2023
@alextreme alextreme deleted the feature/1047-add-upload-to-case-detailview branch January 31, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants