Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1056] Feature/add second logo field #433

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Jan 20, 2023

Since there is no specific design for this, I kept it on the left side and I didn't change the grid concerning the image (it is expanded to the whole grid horizontally). Perhaps this should be reviewed by Svenv as well

@codecov-commenter
Copy link

Codecov Report

Merging #433 (d5867c6) into develop (41062e3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #433   +/-   ##
========================================
  Coverage    96.30%   96.30%           
========================================
  Files          470      471    +1     
  Lines        15667    15677   +10     
========================================
+ Hits         15088    15098   +10     
  Misses         579      579           
Impacted Files Coverage Δ
.../open_inwoner/components/templatetags/link_tags.py 100.00% <ø> (ø)
.../open_inwoner/components/templatetags/logo_tags.py 100.00% <ø> (ø)
src/open_inwoner/configurations/admin.py 100.00% <ø> (ø)
...nfigurations/migrations/0030_auto_20230120_1331.py 100.00% <100.00%> (ø)
src/open_inwoner/configurations/models.py 98.38% <100.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"hmm" about CSS Grid approach in the footer, but this issue is unrelated to that and solves the problem imho.

@alextreme alextreme merged commit 82089f2 into develop Jan 24, 2023
@alextreme alextreme deleted the feature/1056-add-second-logo branch January 24, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants