-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1052-4]Feature/ haalcentraal contact data #430
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #430 +/- ##
===========================================
+ Coverage 96.28% 96.29% +0.01%
===========================================
Files 469 470 +1
Lines 15596 15640 +44
===========================================
+ Hits 15017 15061 +44
Misses 579 579
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
36a8bb1
to
88172a4
Compare
88172a4
to
ecce86d
Compare
General idea is good, however thinking about the edit-profile view there isn't much point in showing all the disabled fields if the User is prepopulated, and the opt-out structure feels a bit brittle (easy to add new fields to the form that might be made editable by accident). How about we go for 2 forms: one where the User is prepopulated and one where this isn't the case. The former would only contain the fields that are actually editable. |
@alextreme I agree, the only reason I did this in one form was because the task is about making specific fields readonly. Now that we are going for two separate forms this does not seem to be needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine. Was there a separate task for updating the NecessaryUserForm?
Yes, this is the task (#1055) that I am working now. |
In this PR I added an extra check (
is_prepopulated=True
, which is True when we use BRP in combination with DigiD) in order to disable the fields and showMijn gegevens
to the user.If we want the form fields disabled generally with DigiD I will have to update this accordingly.