Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#976] Implemented first Playwright tests for action status toggle #404

Merged
merged 9 commits into from
Dec 23, 2022

Conversation

Bartvaderkin
Copy link
Contributor

WIP to see if this runs on CI

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2022

Codecov Report

Merging #404 (08a8d2d) into develop (0eefaeb) will increase coverage by 0.23%.
The diff coverage is 63.15%.

@@             Coverage Diff             @@
##           develop     #404      +/-   ##
===========================================
+ Coverage    96.13%   96.36%   +0.23%     
===========================================
  Files          463      464       +1     
  Lines        15196    15196              
===========================================
+ Hits         14608    14644      +36     
+ Misses         588      552      -36     
Impacted Files Coverage Δ
...c/open_inwoner/accounts/tests/test_action_views.py 88.53% <36.11%> (+1.80%) ⬆️
src/open_inwoner/accounts/tests/test_inbox_page.py 93.57% <65.38%> (+17.38%) ⬆️
src/open_inwoner/utils/tests/playwright.py 71.66% <71.66%> (ø)
src/open_inwoner/accounts/tests/factories.py 100.00% <100.00%> (ø)
src/open_inwoner/plans/tests/test_views.py 100.00% <100.00%> (+1.50%) ⬆️
...pen_inwoner/components/templatetags/string_tags.py 91.66% <0.00%> (-8.34%) ⬇️
src/open_inwoner/configurations/models.py 92.30% <0.00%> (ø)
...nfigurations/migrations/0029_auto_20221221_1636.py 100.00% <0.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Bartvaderkin
Copy link
Contributor Author

👍 Playwright seems to work great on CI! 🥳

@Bartvaderkin Bartvaderkin changed the title WIP [#976] Implemented first Playwright tests for action status toggle [#976] Implemented first Playwright tests for action status toggle Dec 22, 2022
@alextreme
Copy link
Member

Playwright seems trivial to install and the tests are imho much more readable than Selenium. I wouldn't mind merging this in to see how it goes over the next few weeks, it's better than the disabled Seleniumtests.

Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with playwright but went through this and seems nice. Since my local machine and the CI are happy let's give it a try!
And by the way, I don't know if this is still draft for some reason or by mistake.

src/open_inwoner/plans/tests/test_views.py Show resolved Hide resolved
@alextreme alextreme marked this pull request as ready for review December 23, 2022 17:24
@alextreme alextreme merged commit d041225 into develop Dec 23, 2022
@alextreme alextreme deleted the issue/976-frontend-tests branch December 23, 2022 17:24
@alextreme
Copy link
Member

If there was a reason why it's still a draft we'll see soon enough :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants