Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruff to ci #1613

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Add ruff to ci #1613

merged 3 commits into from
Feb 10, 2025

Conversation

swrichards
Copy link
Collaborator

No description provided.

@swrichards swrichards force-pushed the add-ruff-to-ci branch 4 times, most recently from bd82979 to 40d3843 Compare February 10, 2025 15:49
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Why was src/openklant2/tests/test_partij.py modified?
  • Minor suggestion about the check concerning trailing whitespace

This introduces ruff to the CI in two flavours:

1. A full repo run, which will not fail the pipeline on errors but
   serves as a convenient check of progress to 100% on legacy code.
2. A run purely on changed files for a PR, to ensure that new code
   is ruff compliant.
@swrichards swrichards marked this pull request as ready for review February 10, 2025 16:15
@swrichards swrichards merged commit 6211326 into develop Feb 10, 2025
21 of 24 checks passed
@swrichards swrichards deleted the add-ruff-to-ci branch February 10, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants