[#2831] Fix contactform math captcha #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-sigma
force-pushed
the
issue/2831-mathcaptcha
branch
5 times, most recently
from
c9f8622
to
949e6d3
Compare
pi-sigma
changed the title
pi-sigma
force-pushed
the
issue/2831-mathcaptcha
branch
from
949e6d3
to
98ae3f3
Compare
- replace dedicated MathCaptcha field with simple IntegerField
and perform actual captcha logic in the form view (the field
was not thread-safe, the values - question + answer - had to
be stored in the session, so there is no reason to keep the
field)
pi-sigma
force-pushed
the
issue/2831-mathcaptcha
branch
from
98ae3f3
to
a3c0487
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1462 +/- ##
===========================================
- Coverage 94.59% 94.59% -0.01%
===========================================
Files 1063 1063
Lines 39681 39672 -9
===========================================
- Hits 37537 37527 -10
- Misses 2144 2145 +1 ☔ View full report in Codecov by Sentry. |
swrichards
approved these changes
Oct 28, 2024
|
I haven't heard complaints about the captcha, but is this issue worthwhile to release a 1.22.2? If not I'll remove the label |
Bobby suggested it was a pressing issue for at least one gemeente, but we'll check in the meeting this morning. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MathCaptchafield on the contactform is replaced with a simpleIntegerFieldand the captcha logic is moved to the contactform view.Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2831