[#2830] Properly expose ADMIN_OIDC setup configuration to docker-compose #1459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1459 +/- ##
========================================
Coverage 94.59% 94.59%
========================================
Files 1063 1063
Lines 39681 39681
========================================
Hits 37537 37537
Misses 2144 2144 ☔ View full report in Codecov by Sentry. |
swrichards
force-pushed
the
issues/2830-admin-oidc-setup-in-docker-compose
branch
3 times, most recently
from
3c6f3cc to
03ae3c5
Compare
Default enable makes life more difficult on the deployment side: containers are more likely to fail on start-up, and deploys become harder to reason about, making it more difficult to only target a single config block.
swrichards
force-pushed
the
issues/2830-admin-oidc-setup-in-docker-compose
branch
from
03ae3c5 to
d756d02
Compare
pi-sigma
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga-2830.