Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update django_setup_configuration docs for SiteConfiguration #1386

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Sep 6, 2024

The PR that introduced the automatic check of setup_configuration docs was merged without rebasing after changes to SiteConfiguration had been introduced, hence the failing test.

@pi-sigma pi-sigma force-pushed the chore/update-setup-config-docs branch from 2c3e00b to fc9c1b8 Compare September 6, 2024 10:31
@pi-sigma pi-sigma force-pushed the chore/update-setup-config-docs branch from fc9c1b8 to 075eed5 Compare September 6, 2024 10:39
@pi-sigma pi-sigma marked this pull request as ready for review September 6, 2024 10:58
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.24%. Comparing base (e9a8176) to head (075eed5).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1386   +/-   ##
========================================
  Coverage    95.24%   95.24%           
========================================
  Files         1006     1006           
  Lines        37313    37313           
========================================
  Hits         35538    35538           
  Misses        1775     1775           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alextreme alextreme merged commit 9de71dd into develop Sep 6, 2024
19 checks passed
@alextreme alextreme deleted the chore/update-setup-config-docs branch September 6, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants