Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync user's notification preferences from klant upon login #1364

Merged
merged 4 commits into from
Aug 21, 2024

Conversation

swrichards
Copy link
Contributor

@swrichards swrichards commented Aug 21, 2024

Note that this PR also contains a fix for the misnamed toestemming_zaak_notificaties_alleen_digitaal on the Klant API model (was camel-cased) and some slight refactoring of the hooks for readability and composability.

It might be best to go commit-for-commit: the actual change is in the last commit.

@swrichards swrichards marked this pull request as ready for review August 21, 2024 12:55
@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.20%. Comparing base (a430792) to head (d69d45c).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1364      +/-   ##
===========================================
+ Coverage    95.19%   95.20%   +0.01%     
===========================================
  Files         1002     1003       +1     
  Lines        37029    37169     +140     
===========================================
+ Hits         35248    35388     +140     
  Misses        1781     1781              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/open_inwoner/openklant/services.py Outdated Show resolved Hide resolved
@swrichards swrichards force-pushed the issues/2695-sync-notification-preferences-on-login branch from 2d0625e to d69d45c Compare August 21, 2024 14:43
@alextreme alextreme merged commit 6eeaea7 into develop Aug 21, 2024
18 checks passed
@alextreme alextreme deleted the issues/2695-sync-notification-preferences-on-login branch August 21, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants