Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a ZGW data import/export flow to the admin panel #1348

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

swrichards
Copy link
Contributor

@swrichards swrichards commented Aug 14, 2024

Two notes:

  1. Contrary to what I reported earlier, I've decided that the cost of doing this synchronously is acceptable (~6s on my machine for a 3k row dump). So no Celery complications here for now, we can re-introduce it if we run into issues in production.
  2. This is only the case if you turn DEBUG off, that's what was causing the slowness. If you want to test this locally, make sure you set DEBUG = False (unless you have local configuration which addresses this, you won't see any assets, which is annoying but not blocking).

@swrichards swrichards changed the title Add a ZGW data import/export flow Add a ZGW data import/export flow to the admin panel Aug 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.18%. Comparing base (281d769) to head (8c7624f).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1348      +/-   ##
===========================================
+ Coverage    95.17%   95.18%   +0.01%     
===========================================
  Files         1001     1001              
  Lines        36921    37012      +91     
===========================================
+ Hits         35140    35231      +91     
  Misses        1781     1781              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards force-pushed the tasks/2649-zgw-import-export branch 4 times, most recently from 0d45af3 to 8761f46 Compare August 16, 2024 10:55
@swrichards swrichards marked this pull request as ready for review August 16, 2024 10:55
src/open_inwoner/openzaak/admin.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/admin.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/admin.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/admin.py Show resolved Hide resolved
src/open_inwoner/openzaak/tests/test_admin.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/tests/test_admin.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/tests/test_admin.py Outdated Show resolved Hide resolved
@swrichards swrichards force-pushed the tasks/2649-zgw-import-export branch 2 times, most recently from 00fcd11 to 61fccec Compare August 16, 2024 13:40
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A template was supposedly changed but is still the same. It's a minor thing though.

Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be merged after CI passes

@swrichards swrichards merged commit f368210 into develop Aug 16, 2024
18 checks passed
@swrichards swrichards deleted the tasks/2649-zgw-import-export branch August 16, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants