[#2640] Use separate field for storing long case result descriptions #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi-sigma
force-pushed
the
task/2640-result-type-description
branch
2 times, most recently
from
cdce6fe
to
b1a10b0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1324 +/- ##
===========================================
- Coverage 95.09% 95.09% -0.01%
===========================================
Files 992 992
Lines 36164 36174 +10
===========================================
+ Hits 34389 34398 +9
- Misses 1775 1776 +1 ☔ View full report in Codecov by Sentry. |
pi-sigma
force-pushed
the
task/2640-result-type-description
branch
3 times, most recently
from
60112ae
to
148870e
Compare
swrichards
requested changes
Aug 5, 2024
- Group mocks according to API (Catalogi API, Documenten API etc.)
- Sort API mocks according to order of dependency (e.g. Zaken API
depends on Catalogi API but not vice versa)
pi-sigma
force-pushed
the
task/2640-result-type-description
branch
from
148870e
to
292d399
Compare
swrichards
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The E-suite occasionally returns case results with descriptions that are longer than allowed by the ZGW spec (20 characters). Updating the E-suite for a single attribute is not an option. The workaround is to store longer descriptions in a dedicated attribute "naam" on
ResultaatTypeand use it if it's non-empy, otherwise fall back on default description ("omschrijving").Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/2640