Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2637] Support import/export of ZaakTypeConfig #1321

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma force-pushed the task/2637-zaatype-config-export branch from b0ac6e0 to 903f6e2 Compare July 24, 2024 12:18
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (6874482) to head (facc5a6).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1321   +/-   ##
========================================
  Coverage    95.14%   95.14%           
========================================
  Files          993      993           
  Lines        35966    35967    +1     
========================================
+ Hits         34220    34221    +1     
  Misses        1746     1746           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review July 25, 2024 07:58
@pi-sigma pi-sigma requested a review from swrichards July 25, 2024 07:59
@pi-sigma pi-sigma force-pushed the task/2637-zaatype-config-export branch from 903f6e2 to facc5a6 Compare July 25, 2024 08:34
Copy link
Contributor

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: as there were no more specific constraints mentioned in the acceptance criteria, this seems like a fine starting point to potentially get more feedback.

@pi-sigma pi-sigma merged commit 4a3404d into develop Jul 29, 2024
18 checks passed
@pi-sigma pi-sigma deleted the task/2637-zaatype-config-export branch July 29, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants