Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2483] Update cases listview to show the combined data from multiple endpoints #1317

Merged
merged 2 commits into from
Jul 18, 2024
Merged

[#2483] Update cases listview to show the combined data from multiple endpoints #1317

merged 2 commits into from
Jul 18, 2024

Conversation

swrichards
Copy link
Contributor

@swrichards swrichards requested a review from pi-sigma July 18, 2024 15:42
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.97980% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.13%. Comparing base (7806ba4) to head (124a00d).
Report is 2 commits behind head on develop.

Files Patch % Lines
src/open_inwoner/openzaak/models.py 81.25% 3 Missing ⚠️
src/open_inwoner/openzaak/tests/test_cases.py 99.29% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #1317   +/-   ##
========================================
  Coverage    95.12%   95.13%           
========================================
  Files          990      990           
  Lines        35769    35863   +94     
========================================
+ Hits         34026    34119   +93     
- Misses        1743     1744    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@swrichards swrichards marked this pull request as ready for review July 18, 2024 15:53
pi-sigma
pi-sigma requested changes Jul 18, 2024
View reviewed changes
src/open_inwoner/cms/cases/views/cases.py Show resolved Hide resolved
src/open_inwoner/cms/cases/views/cases.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/cases.py Show resolved Hide resolved
src/open_inwoner/openzaak/cases.py Show resolved Hide resolved
@swrichards swrichards force-pushed the features/2483-cases-are-multi-backend-aware branch from 124a00d to dabd60c Compare July 18, 2024 17:48
@swrichards swrichards force-pushed the features/2483-cases-are-multi-backend-aware branch from dabd60c to 4749eec Compare July 18, 2024 18:04
@swrichards swrichards requested a review from pi-sigma July 18, 2024 18:07
@swrichards swrichards merged commit f312d13 into develop Jul 18, 2024
18 checks passed
@swrichards swrichards deleted the features/2483-cases-are-multi-backend-aware branch July 18, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi-sigma pi-sigma pi-sigma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swrichards @codecov-commenter @pi-sigma