Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [#2381] Make zakelijk tab hidden when eHerkenning is off #1191

Merged
merged 1 commit into from
May 13, 2024

Conversation

jiromaykin
Copy link
Contributor

@jiromaykin jiromaykin commented Apr 30, 2024

@jiromaykin jiromaykin force-pushed the fix/2381-hide-zakelijk-if-false branch from 8eda367 to 9d01f97 Compare April 30, 2024 15:33
@jiromaykin jiromaykin changed the title [#2381] Make zakelijk tab hidden when eHerkenning is false [#2381] Make zakelijk tab hidden when eHerkenning is off Apr 30, 2024
@alextreme
Copy link
Member

FYI, the issue for this PR has been marked as blocking the 1.16 release for Groningen

@jiromaykin jiromaykin force-pushed the fix/2381-hide-zakelijk-if-false branch from 9d01f97 to 1a43307 Compare May 13, 2024 07:48
@jiromaykin jiromaykin marked this pull request as ready for review May 13, 2024 07:48
@jiromaykin jiromaykin changed the title [#2381] Make zakelijk tab hidden when eHerkenning is off 🐛 [#2381] Make zakelijk tab hidden when eHerkenning is off May 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (9de9afb) to head (25a5836).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1191   +/-   ##
========================================
  Coverage    95.21%   95.21%           
========================================
  Files          958      958           
  Lines        34638    34638           
========================================
  Hits         32981    32981           
  Misses        1657     1657           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alextreme alextreme requested a review from pi-sigma May 13, 2024 08:48
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be preferable to hide the particulier tab as well if eHerkenning is disabled. There is no point in having a single tab.

@jiromaykin jiromaykin force-pushed the fix/2381-hide-zakelijk-if-false branch from ebad54f to 25a5836 Compare May 13, 2024 10:57
@jiromaykin jiromaykin requested a review from pi-sigma May 13, 2024 11:55
@alextreme alextreme merged commit ba2a661 into develop May 13, 2024
15 checks passed
@alextreme alextreme deleted the fix/2381-hide-zakelijk-if-false branch May 13, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants