-
Notifications
You must be signed in to change notification settings - Fork 6
💄 [#2064] Fix userfeed styling #1180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1180 +/- ##
========================================
Coverage 95.18% 95.18%
========================================
Files 956 956
Lines 34603 34603
========================================
Hits 32937 32937
Misses 1666 1666 ☔ View full report in Codecov by Sentry. |
0b2dd55
to
0d66ef4
Compare
8c6c50b
to
eaeeafb
Compare
88e6391
to
0e49907
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I noticed two departures from the design:
(1) in the design the the text is bold (ours is regular)
(2) in the design the arrow is always centered in the box (on our end it's aligned with the bottom line of the text)
Double-check that this is as intended, then we're good to go.
@pi-sigma Let's look at this together again, because
![]() |
@pi-sigma I checked again to see if it looks weird, but it doesn't. For the larger cards, like Vragen we also have the arrows 'sticking' to the bottoms of the cards, not the center. ![]() |
issue: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2064
based on design: https://www.figma.com/file/iKGhWhstaLIlFSaND2q7cE/OIP---Designs-(new)?type=design&node-id=1460%3A5026&mode=dev
Fixing heading(=description) styling + improved the pseudo-element spacing a bit ;
not yet adding the arrow link, will be new issue if actually needed in future.
Note: I have also changed the order and HTML semantics, as this relates to this issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2352