🐛 [#2284] Remove hardcoded CMS app namespace for selected categories #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
fix/2284-incorrect-apphook-namespace
branch
from
d80daaa
to
225ec83
Compare
stevenbal
force-pushed
the
fix/2284-incorrect-apphook-namespace
branch
from
225ec83
to
5ca7b8c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1179 +/- ##
===========================================
- Coverage 95.13% 95.13% -0.01%
===========================================
Files 957 957
Lines 34645 34651 +6
===========================================
+ Hits 32960 32964 +4
- Misses 1685 1687 +2 ☔ View full report in Codecov by Sentry. |
|
haha whoops |
stevenbal
changed the title
stevenbal
force-pushed
the
fix/2284-incorrect-apphook-namespace
branch
from
5ca7b8c
to
5b54788
Compare
|
Would have been fun in the releasenotes too :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://taiga.maykinmedia.nl/project/open-inwoner/issue/2284
This worked locally, because in the datadump the apphook namespace was
"profile", but this didn't work for Groningen on their acceptance environment