Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ [#2324] Add test for setup_configuration command #1165

Merged

Conversation

stevenbal
Copy link
Contributor

No description provided.

Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be a little dryer? Every step exists 4 times here (one as patch, three as new instances), and there are quite a lot.

If you have one list of the classes you can generate the rest from it.

Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, so dynamic.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.13%. Comparing base (2f1547e) to head (10b3c2d).

Additional details and impacted files
@@                       Coverage Diff                       @@
##           feature/2263-setup-config-auth    #1165   +/-   ##
===============================================================
  Coverage                           95.12%   95.13%           
===============================================================
  Files                                 952      953    +1     
  Lines                               34529    34564   +35     
===============================================================
+ Hits                                32846    32881   +35     
  Misses                               1683     1683           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alextreme alextreme merged commit 957969e into feature/2263-setup-config-auth Apr 19, 2024
12 checks passed
@alextreme alextreme deleted the feature/2324-setup-config-tests branch April 19, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants