Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applied pyupgrade to project #1159

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Applied pyupgrade to project #1159

merged 1 commit into from
Apr 18, 2024

Conversation

Bartvaderkin
Copy link
Contributor

I saw this in the general chat and was curious.

src/open_inwoner/apimock/views.py Dismissed Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.79832% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 95.05%. Comparing base (a47782f) to head (a4f46d7).

Files Patch % Lines
src/open_inwoner/accounts/admin.py 0.00% 1 Missing ⚠️
src/open_inwoner/accounts/models.py 0.00% 1 Missing ⚠️
src/open_inwoner/cms/cases/tests/test_htmx.py 0.00% 1 Missing ⚠️
src/open_inwoner/custom_csp/middleware.py 0.00% 1 Missing ⚠️
src/open_inwoner/utils/geocode.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1159      +/-   ##
===========================================
- Coverage    95.05%   95.05%   -0.01%     
===========================================
  Files          950      950              
  Lines        33790    33789       -1     
===========================================
- Hits         32119    32118       -1     
  Misses        1671     1671              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bartvaderkin Bartvaderkin marked this pull request as ready for review April 16, 2024 07:49
Copy link
Contributor

@pi-sigma pi-sigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, especially the formatted strings! Did you run the script manually or do you have a githook?

@Bartvaderkin
Copy link
Contributor Author

I just ran it manually for now, it is not that important.

@stevenbal stevenbal merged commit 1490208 into develop Apr 18, 2024
15 checks passed
@stevenbal stevenbal deleted the fix/pyupgrade branch April 18, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants