Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#2242] Add CMS plugin for mijn afspraken #1121

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Mar 26, 2024

@stevenbal stevenbal marked this pull request as draft March 26, 2024 14:37
@stevenbal stevenbal force-pushed the feature/2242-mijn-afspraken-plugin branch from baa0bde to a4b851c Compare March 26, 2024 15:41
@stevenbal stevenbal marked this pull request as ready for review March 26, 2024 15:41
Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More questions than actual change-requests 🙃

@@ -0,0 +1,54 @@
.plugin-card {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems specific to Userfeed? We do have multiple plugin-cards, but apparently those do not need this styling...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I'd make this generic, because the appointments plugin cards have (almost) the same styling and I didn't want to duplicate it:

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK - seems like the appointments don't need a notification color (yet) so approving this now.

Bartvaderkin

This comment was marked as outdated.

Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty neat, only gripe I have is the name. I'd propose to call the whole thing UserAppointments instead of MyAppointments, similar to UserFeed. Because 'me' and 'my' names are a bit django tutorial and technically it can display any user.

@stevenbal stevenbal force-pushed the feature/2241-mijn-afspraken-list-design branch 2 times, most recently from f52ec42 to 97a9c86 Compare March 28, 2024 09:51
@stevenbal stevenbal force-pushed the feature/2242-mijn-afspraken-plugin branch 2 times, most recently from d453a06 to 7afe6ff Compare March 28, 2024 10:36
@stevenbal stevenbal force-pushed the feature/2242-mijn-afspraken-plugin branch from 7afe6ff to 91b2ef0 Compare March 28, 2024 11:17
@jiromaykin jiromaykin self-requested a review March 28, 2024 16:28
Base automatically changed from feature/2241-mijn-afspraken-list-design to develop March 29, 2024 08:40
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 95.23810% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 95.04%. Comparing base (97a9c86) to head (5ed758e).
Report is 8 commits behind head on develop.

Files Patch % Lines
...en_inwoner/cms/plugins/cms_plugins/appointments.py 84.00% 4 Missing ⚠️
...rc/open_inwoner/cms/plugins/models/appointments.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1121      +/-   ##
===========================================
- Coverage    95.05%   95.04%   -0.01%     
===========================================
  Files          923      928       +5     
  Lines        32364    32441      +77     
===========================================
+ Hits         30763    30835      +72     
- Misses        1601     1606       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal merged commit b647e63 into develop Apr 4, 2024
15 checks passed
@stevenbal stevenbal deleted the feature/2242-mijn-afspraken-plugin branch April 4, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants