-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [#2242] Add CMS plugin for mijn afspraken #1121
Conversation
baa0bde
to
a4b851c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More questions than actual change-requests 🙃
src/open_inwoner/scss/components/Appointments/Appointments.scss
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,54 @@ | |||
.plugin-card { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems specific to Userfeed? We do have multiple plugin-cards, but apparently those do not need this styling...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK - seems like the appointments don't need a notification color (yet) so approving this now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty neat, only gripe I have is the name. I'd propose to call the whole thing UserAppointments instead of MyAppointments, similar to UserFeed. Because 'me' and 'my' names are a bit django tutorial and technically it can display any user.
f52ec42
to
97a9c86
Compare
d453a06
to
7afe6ff
Compare
7afe6ff
to
91b2ef0
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1121 +/- ##
===========================================
- Coverage 95.05% 95.04% -0.01%
===========================================
Files 923 928 +5
Lines 32364 32441 +77
===========================================
+ Hits 30763 30835 +72
- Misses 1601 1606 +5 ☔ View full report in Codecov by Sentry. |
task: https://taiga.maykinmedia.nl/project/open-inwoner/task/2242