-
Notifications
You must be signed in to change notification settings - Fork 6
♻️ [#2193] Replace django-better-admin-arrayfield with django-jsonform #1087
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d0fc60b
to
b90b562
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, little bit triggered by changing old migrations but I suppose it makes sense as the imports would break if we remove the old dependency and it just builds on normal ArrayField.
What is strange there is one new migration, while the others could be changed in place. Is this as expected?
Hmm, I think this is because I first upgraded |
Ok makes sense, didn't catch that. |
django-jsonform requires JS to work properly and in WebTest the ArrayFields get an empty string as their default value, which causes the form to crash because it tries to parse the value as JSON
d09bfde
to
646b1ec
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1087 +/- ##
========================================
Coverage 95.00% 95.00%
========================================
Files 895 896 +1
Lines 31438 31449 +11
========================================
+ Hits 29868 29879 +11
Misses 1570 1570 ☔ View full report in Codecov by Sentry. |
issue: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2193
also upgrades
mozilla-django-oidc-db
to get rid ofdjango-better-admin-arrayfield
The

Category.zaaktypen
select widget looks a little different, but I think it works better this wayPreviously it looked like this, where each entry had its own dropdown:
