Skip to content

♻️ [#2193] Replace django-better-admin-arrayfield with django-jsonform #1087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 12, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Mar 11, 2024

issue: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2193

also upgrades mozilla-django-oidc-db to get rid of django-better-admin-arrayfield

The Category.zaaktypen select widget looks a little different, but I think it works better this way
Screenshot 2024-03-12 at 10-27-58 Onderwerp wijzigen Open Inwoner beheeromgeving

Previously it looked like this, where each entry had its own dropdown:
image

@stevenbal stevenbal marked this pull request as draft March 11, 2024 16:21
@stevenbal stevenbal force-pushed the fix/2193-replace-better-admin-arrayfield branch from d0fc60b to b90b562 Compare March 12, 2024 09:39
@stevenbal stevenbal marked this pull request as ready for review March 12, 2024 09:45
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, little bit triggered by changing old migrations but I suppose it makes sense as the imports would break if we remove the old dependency and it just builds on normal ArrayField.

What is strange there is one new migration, while the others could be changed in place. Is this as expected?

@stevenbal
Copy link
Contributor Author

What is strange there is one new migration, while the others could be changed in place. Is this as expected?

Hmm, I think this is because I first upgraded mozilla-django-oidc-db (which introduced django-jsonform), then ran makemigrations and then later replaced better-admin-arrayfield with django-jsonform in our project

@Bartvaderkin
Copy link
Contributor

What is strange there is one new migration, while the others could be changed in place. Is this as expected?

Hmm, I think this is because I first upgraded mozilla-django-oidc-db (which introduced django-jsonform), then ran makemigrations and then later replaced better-admin-arrayfield with django-jsonform in our project

Ok makes sense, didn't catch that.

@stevenbal stevenbal requested a review from Bartvaderkin March 12, 2024 15:19
@stevenbal stevenbal force-pushed the fix/2193-replace-better-admin-arrayfield branch from d09bfde to 646b1ec Compare March 12, 2024 15:52
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.00%. Comparing base (3a27bb2) to head (646b1ec).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1087   +/-   ##
========================================
  Coverage    95.00%   95.00%           
========================================
  Files          895      896    +1     
  Lines        31438    31449   +11     
========================================
+ Hits         29868    29879   +11     
  Misses        1570     1570           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal merged commit 3bbd1a3 into develop Mar 12, 2024
17 checks passed
@stevenbal stevenbal deleted the fix/2193-replace-better-admin-arrayfield branch March 12, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants