[#2175] Fix rounded corners for mail-templates #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1078 +/- ##
========================================
Coverage 95.00% 95.00%
========================================
Files 894 894
Lines 31427 31427
========================================
Hits 29857 29857
Misses 1570 1570 ☔ View full report in Codecov by Sentry. |
jiromaykin
changed the title
jiromaykin
force-pushed
the
fix/2175-rounded-corners-mail
branch
4 times, most recently
from
7384bbc
to
f47523f
Compare
jiromaykin
force-pushed
the
fix/2175-rounded-corners-mail
branch
3 times, most recently
from
021597d
to
714908d
Compare
stevenbal
reviewed
Mar 11, 2024
stevenbal
approved these changes
Mar 11, 2024
jiromaykin
force-pushed
the
fix/2175-rounded-corners-mail
branch
from
6acecb1
to
4169b13
Compare
jiromaykin
force-pushed
the
fix/2175-rounded-corners-mail
branch
from
da17976
to
c38b934
Compare
Bartvaderkin
approved these changes
Mar 12, 2024
stevenbal
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2175
This fix does not use fallbacks, instead the issue was that the Table with rounded area got a white background, which cut through the rounded corners and made it seem not-rounded.
PS: the border-radiuses in the design are only 3px so not dramatically visible.