Fixed user save-signal issue with Haalcentraal BRP retrieval logging #1062
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was kind of gnarly:
pre_save
signal because we need a saved userpre_save
orpost_save
handler creates a signal loopSolution: use
post_save
so we have a saved user, and break the loop.Downside is this will trigger any other
post_save
handler multiple times, which is a vote to centralize signal based user update stuff. Most of it is currentlyuser_logged_in
so not an issue.Note this PR targets the open Django 4.x branch #1024