Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ [#2112] Retrieve open tasks on login and store in userfeed #1057

Merged
merged 4 commits into from
Feb 29, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Feb 26, 2024

@stevenbal stevenbal marked this pull request as draft February 26, 2024 16:12
@stevenbal stevenbal force-pushed the feature/2112-userfeed-external-tasks branch 3 times, most recently from f111e30 to 80162c0 Compare February 27, 2024 13:11
@stevenbal stevenbal changed the title 🚧 [#2112] initial work ✨ [#2112] Retrieve open tasks on login and store in userfeed Feb 27, 2024
@stevenbal stevenbal force-pushed the feature/2112-userfeed-external-tasks branch from 80162c0 to 7f25019 Compare February 27, 2024 13:36
@stevenbal stevenbal marked this pull request as ready for review February 27, 2024 13:46
@alextreme alextreme requested review from pi-sigma and removed request for alextreme February 27, 2024 18:30
Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some notes, but also used this as a good demo case for practical testing with mock/patch.

src/open_inwoner/userfeed/hooks/external_task.py Outdated Show resolved Hide resolved
src/open_inwoner/userfeed/hooks/external_task.py Outdated Show resolved Hide resolved
src/open_inwoner/userfeed/hooks/external_task.py Outdated Show resolved Hide resolved
src/open_inwoner/userfeed/tests/test_external_tasks.py Outdated Show resolved Hide resolved
src/open_inwoner/userfeed/tests/test_external_tasks.py Outdated Show resolved Hide resolved
src/open_inwoner/openzaak/tests/mocks.py Show resolved Hide resolved
@stevenbal stevenbal force-pushed the feature/2112-userfeed-external-tasks branch from 7f25019 to 3f8aead Compare February 29, 2024 10:24
@stevenbal
Copy link
Contributor Author

@Bartvaderkin I made has_change_permission and has_add_permission conditional based on settings.DEBUG, to make local development a bit easier

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 96.10390% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 94.95%. Comparing base (d11a962) to head (3f8aead).

Files Patch % Lines
src/open_inwoner/openzaak/clients.py 63.63% 4 Missing ⚠️
src/open_inwoner/userfeed/admin.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           develop    #1057    +/-   ##
=========================================
  Coverage    94.94%   94.95%            
=========================================
  Files          883      886     +3     
  Lines        30950    31099   +149     
=========================================
+ Hits         29386    29530   +144     
- Misses        1564     1569     +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, much clearer.

I put a style note about dicts because the distinction helps a lot in reading existing code.

src/open_inwoner/userfeed/hooks/external_task.py Outdated Show resolved Hide resolved
src/open_inwoner/userfeed/hooks/external_task.py Outdated Show resolved Hide resolved
@stevenbal stevenbal force-pushed the feature/2112-userfeed-external-tasks branch from 3f8aead to 6d67846 Compare February 29, 2024 12:52
@stevenbal stevenbal merged commit 18df719 into develop Feb 29, 2024
15 checks passed
@stevenbal stevenbal deleted the feature/2112-userfeed-external-tasks branch February 29, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants