-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ [#2112] Retrieve open tasks on login and store in userfeed #1057
Conversation
f111e30
to
80162c0
Compare
80162c0
to
7f25019
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some notes, but also used this as a good demo case for practical testing with mock/patch.
src/open_inwoner/apimock/apis/esuite-read/formulieren-api/openstaande-taken.json
Outdated
Show resolved
Hide resolved
7f25019
to
3f8aead
Compare
@Bartvaderkin I made |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1057 +/- ##
=========================================
Coverage 94.94% 94.95%
=========================================
Files 883 886 +3
Lines 30950 31099 +149
=========================================
+ Hits 29386 29530 +144
- Misses 1564 1569 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, much clearer.
I put a style note about dicts because the distinction helps a lot in reading existing code.
3f8aead
to
6d67846
Compare
task: https://taiga.maykinmedia.nl/project/open-inwoner/task/2112