🐛 [#2143] Show all categories to staff users

[stevenbal]

issue: https://taiga.maykinmedia.nl/project/open-inwoner/issue/2143

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b0a1d1e) 94.91% compared to head (0533581) 94.91%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1046   +/-   ##
========================================
  Coverage    94.91%   94.91%           
========================================
  Files          882      882           
  Lines        30792    30801    +9     
========================================
+ Hits         29227    29236    +9     
  Misses        1565     1565           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Bartvaderkin]

Readability would improve in cases like this if we don't use random numbered variables but give the categories useful names, like category_anonymous, category_all, category_citizens, category_companies so the test itself is meaningful and you don't have to go back and forth to the setup to read the tests.

And optional note: this test file looks pretty old, can we update it? There are unusual user setups in the setUpTestData(), with passwords and custom email and manual self.client.login(email=self.user.email, password="12345").

That is all irrelevant to the test, and passwords are actually already set in the factory 😦 The more recent tests just create an appropriate user right there in the test and do a force_login.