Skip to content

Commit

Permalink
👌 [#1802] Process PR feedback
Browse files Browse the repository at this point in the history
* perform zaak search after empty query check and logging
  • Loading branch information
stevenbal committed Nov 2, 2023
1 parent b575f35 commit cb03724
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 8 deletions.
10 changes: 10 additions & 0 deletions src/open_inwoner/search/tests/test_views.py
Original file line number Diff line number Diff line change
Expand Up @@ -284,3 +284,13 @@ def test_search_case_identificatie_cache(self, m):

# Show regular search results page
self.assertEqual(response.status_code, 200)

def test_search_case_empty_query(self, m):
self._setUpMocks(m)

self.client.force_login(self.user)
params = urlencode({"query": ""}, doseq=True)
response = self.client.get(f'{reverse("search:search")}?{params}')

# Show regular search results page
self.assertEqual(response.status_code, 200)
16 changes: 8 additions & 8 deletions src/open_inwoner/search/views.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,14 @@ def search(self, form):
query = data.pop("query")
context = self.get_context_data(form=form)

if not query:
return self.render_to_response(context)

# log search query of authenticated users
user = self.request.user
if user.is_authenticated:
self.log_user_action(user, _("search query: {query}").format(query=query))

# Check if the query exactly matches with a case that belongs to the user
if hasattr(self.request.user, "bsn"):
cases = fetch_cases(self.request.user.bsn, identificatie=query)
Expand All @@ -61,14 +69,6 @@ def search(self, form):
)
)

if not query:
return self.render_to_response(context)

# log search query of authenticated users
user = self.request.user
if user.is_authenticated:
self.log_user_action(user, _("search query: {query}").format(query=query))

# perform search
results = search_products(query, filters=data)

Expand Down

0 comments on commit cb03724

Please sign in to comment.