[#1437 #1457] Cleaned up some comments and todos

src/open_inwoner/openklant/forms.py

@@ -79,6 +79,7 @@ def clean(self, *args, **kwargs):
             self.add_error("phonenumber", msg)
 
         if self.user.is_authenticated:
+            # we need to use get_contact_email() because we use dummy email for BSN users
             if not email and self.user.get_contact_email():
                 cleaned_data["email"] = self.user.get_contact_email()
             if not phonenumber and self.user.phonenumber:

src/open_inwoner/openklant/views/contactform.py

@@ -52,6 +52,7 @@ def get_initial(self):
                     "first_name": self.request.user.first_name,
                     "infix": self.request.user.infix,
                     "last_name": self.request.user.last_name,
+                    # we need to use get_contact_email() because we use dummy email for BSN users
                     "email": self.request.user.get_contact_email(),
                     "phonenumber": self.request.user.phonenumber,
                 }
@@ -113,7 +114,6 @@ def register_by_api(self, form, config: OpenKlantConfig):
                 if not klant.telefoonnummer and form.cleaned_data["phonenumber"]:
                     update_data["telefoonnummer"] = form.cleaned_data["phonenumber"]
                 if update_data:
-                    # TODO add audit log
                     patch_klant(klant, update_data)
                     self.log_system_action(
                         f"patched klant from user with missing fields: {', '.join(sorted(update_data.keys()))}"
@@ -146,8 +146,6 @@ def register_by_api(self, form, config: OpenKlantConfig):
         text = f"{subject}\n\n{question}"
 
         if not klant:
-            # TODO add audit log to note we didn't have a Klant and appended the info to the message
-
             # if we don't have a BSN and can't create a Klant we'll add contact info to the tekst
             parts = [form.cleaned_data[k] for k in ("first_name", "infix", "last_name")]
             full_name = " ".join(p for p in parts if p)