Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#458] Add django setup configuration and ZGW steps #524

Merged
merged 7 commits into from
Dec 5, 2024

Conversation

SilviaAmAm
Copy link
Collaborator

@SilviaAmAm SilviaAmAm commented Nov 28, 2024

Fixes #458

@SilviaAmAm SilviaAmAm marked this pull request as draft November 28, 2024 15:21
@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.06%. Comparing base (f28aec9) to head (95973cd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
+ Coverage   79.98%   80.06%   +0.08%     
==========================================
  Files         202      204       +2     
  Lines        5540     5563      +23     
  Branches      556      556              
==========================================
+ Hits         4431     4454      +23     
  Misses       1109     1109              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SilviaAmAm SilviaAmAm force-pushed the feature/458-add-django-config-zgw branch 3 times, most recently from 8fa92f0 to c06ddef Compare November 29, 2024 10:13
Copy link

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, good pattern to follow for the docker-compose.

@svenvandescheur svenvandescheur removed their request for review December 3, 2024 09:13
@SilviaAmAm SilviaAmAm force-pushed the feature/458-add-django-config-zgw branch from c06ddef to 340ffc3 Compare December 5, 2024 10:11
@SilviaAmAm SilviaAmAm marked this pull request as ready for review December 5, 2024 10:11
@SilviaAmAm SilviaAmAm requested a review from swrichards December 5, 2024 10:11
@SilviaAmAm SilviaAmAm force-pushed the feature/458-add-django-config-zgw branch 2 times, most recently from 3063562 to 76a6752 Compare December 5, 2024 10:48
Copy link

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one outstanding issue/question regarding how to handle the dependency on migrations.

@SilviaAmAm SilviaAmAm force-pushed the feature/458-add-django-config-zgw branch from 37644b2 to 95973cd Compare December 5, 2024 14:28
@SilviaAmAm SilviaAmAm requested a review from swrichards December 5, 2024 14:33
Copy link

@swrichards swrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@SilviaAmAm SilviaAmAm merged commit 135f8a3 into main Dec 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for ZGW configuration via django-setup-configuration
3 participants