-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#458] Add django setup configuration and ZGW steps #524
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #524 +/- ##
==========================================
+ Coverage 79.98% 80.06% +0.08%
==========================================
Files 202 204 +2
Lines 5540 5563 +23
Branches 556 556
==========================================
+ Hits 4431 4454 +23
Misses 1109 1109 ☔ View full report in Codecov by Sentry. |
8fa92f0
to
c06ddef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, good pattern to follow for the docker-compose
.
backend/src/openarchiefbeheer/config/setup_configuration/steps.py
Outdated
Show resolved
Hide resolved
backend/src/openarchiefbeheer/config/setup_configuration/tests/test_setup_configuration.py
Outdated
Show resolved
Hide resolved
backend/src/openarchiefbeheer/config/setup_configuration/tests/test_setup_configuration.py
Outdated
Show resolved
Hide resolved
c06ddef
to
340ffc3
Compare
3063562
to
76a6752
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one outstanding issue/question regarding how to handle the dependency on migrations.
37644b2
to
95973cd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Fixes #458