Feature/#501 abort #517
Feature/#501 abort #517
Conversation
…st (set list status to new)
svenvandescheur
force-pushed
the
feature/#501-abort
branch
from
0350917
to
1a32890
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
==========================================
+ Coverage 75.32% 79.72% +4.40%
==========================================
Files 198 196 -2
Lines 5531 5420 -111
Branches 547 550 +3
==========================================
+ Hits 4166 4321 +155
+ Misses 1365 1099 -266 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
| @action(detail=True, methods=["post"], name="abort-destruction") | ||
| def abort_destruction(self, request, *args, **kwargs): | ||
| @action(detail=True, methods=["post"], name="abort") | ||
| def abort(self, request, *args, **kwargs): |
There was a problem hiding this comment.
The API schema on line 210 needs also updating
There was a problem hiding this comment.
- Update API schema
| name="A test list", | ||
| author=record_manager, | ||
| status=ListStatus.ready_to_review, | ||
| planned_destruction_date=date(2024, 1, 8), |
There was a problem hiding this comment.
The planned_destruction_date is usually only present on lists with status ready_to_delete (but i guess it is to check that it gets cleared all in one test).
There was a problem hiding this comment.
TBH: I've just renamed/altered the existing test, but now you mention it, it is useful in a test setting. We could add another test if you think thats's better?
There was a problem hiding this comment.
My bad 😅 I think we can leave it but maybe with a comment?
backend/src/openarchiefbeheer/logging/templates/logging/destruction_list_aborted.txt
Show resolved
Hide resolved
Fixes #501