-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/django setup configuration mozilla django OIDC db #136
Issue/django setup configuration mozilla django OIDC db #136
Conversation
@danielmursa-dev could you rebase from #135? That will make the git history clearer. |
Commenting this link to make reviewing a bit easier for now |
a69457d
to
8206383
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but lets wait until #135 is merged. Could you also update the documentation and a small section which shows an example of a configuration?
932322a
to
e3f043d
Compare
[maykinmedia/objects-api#480] Fix requirements [maykinmedia/objects-api#480] Remove tests
0401712
to
646dd1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine I think. This was reviewed on my phone though
src/objecttypes/setup_configuration/tests/test_token_auth_config.py
Outdated
Show resolved
Hide resolved
* [maykinmedia/objects-api#480] Setup configuration mozilla django OIDC db [maykinmedia/objects-api#480] Fix requirements [maykinmedia/objects-api#480] Remove tests * [maykinmedia/objects-api#480] Update django-setup-configuration * [maykinmedia/objects-api#480] Update django.contrib.sites.Site configuration * [maykinmedia/objects-api#480] Fix tests after new release * [maykinmedia/objects-api#480] Fix tests * [maykinmedia/objects-api#480] Delete old SiteConfigurationModel * [maykinmedia/objects-api#480] Revert django-setup-configuration version
Fixes maykinmedia/objects-api#480