Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix registering kanalen #17

Merged
merged 12 commits into from
Nov 27, 2024
Merged

Fix registering kanalen #17

merged 12 commits into from
Nov 27, 2024

Conversation

SonnyBA
Copy link
Contributor

@SonnyBA SonnyBA commented Nov 27, 2024

Recently introduced changes caused kanalen not to be registered as the used APIClient now only returns Response objects instead of parsed response data, done previously through the zds_client.client.Client (link).

These changes add the missing parsing that should be done of the responses.

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 98.29060% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.76%. Comparing base (aa73035) to head (f6e69a7).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...api_common/management/commands/register_kanalen.py 93.93% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   90.19%   91.76%   +1.56%     
==========================================
  Files          29       31       +2     
  Lines         602      753     +151     
==========================================
+ Hits          543      691     +148     
- Misses         59       62       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SonnyBA SonnyBA marked this pull request as ready for review November 27, 2024 11:36
@SonnyBA SonnyBA self-assigned this Nov 27, 2024
Copy link
Contributor

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor remarks

CHANGELOG.rst Outdated
------------------

* Fixed kanalen not being registered. This regression was introduced in `0.3.0`
(through `aa73035c285f7f5157148034a0e87149b6e1bcf0`).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the commit hash is a little extensive, the issue number should be enough

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was no issue created for this but I removed the commit hash

Copy link
Contributor

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@SonnyBA SonnyBA merged commit b559acc into main Nov 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants