-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix registering kanalen #17
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17 +/- ##
==========================================
+ Coverage 90.19% 91.76% +1.56%
==========================================
Files 29 31 +2
Lines 602 753 +151
==========================================
+ Hits 543 691 +148
- Misses 59 62 +3 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just minor remarks
CHANGELOG.rst
Outdated
------------------ | ||
|
||
* Fixed kanalen not being registered. This regression was introduced in `0.3.0` | ||
(through `aa73035c285f7f5157148034a0e87149b6e1bcf0`). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the commit hash is a little extensive, the issue number should be enough
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was no issue created for this but I removed the commit hash
notifications_api_common/management/commands/register_kanalen.py
Outdated
Show resolved
Hide resolved
notifications_api_common/management/commands/register_kanalen.py
Outdated
Show resolved
Hide resolved
notifications_api_common/management/commands/register_kanalen.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
notifications_api_common/management/commands/register_kanalen.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Anna Shamray <[email protected]>
Recently introduced changes caused kanalen not to be registered as the used
APIClient
now only returnsResponse
objects instead of parsed response data, done previously through thezds_client.client.Client
(link).These changes add the missing parsing that should be done of the responses.