Skip to content

Add django-setup-configuration as optional dependancy for mozilla-django-oidc-db to autoconfigure the Admin OIDC for our components #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
alextreme opened this issue Jul 8, 2024 · 4 comments · Fixed by #115
Closed

Add django-setup-configuration as optional dependancy for mozilla-django-oidc-db to autoconfigure the Admin OIDC for our components #114

alextreme opened this issue Jul 8, 2024 · 4 comments · Fixed by #115
Assignees
@swrichards @Coperh @stevenbal
Labels
enhancement New feature or request owner: dimpact

Comments

@alextreme
Copy link
Member

Taiga OIP 2607

Hey all, I saw that you added Admin-OIDC support via SetupConfig. It would be great if this can be part of the mozilla-django-oidc-db library as a contrib or optional dep, so we can use it in ALL our products.

Its about this piece of code: https://github.com/maykinmedia/open-inwoner/blob/ab1950d4f71ed85c1819dfcb69f027fba196c763/src/open_inwoner/configurations/bootstrap/auth.py#L198

So the idea is that we have a mozilla-django-oidc-db[setupconfig] (see https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#optional-dependencies ) which ensures django-setup-configuration is installed and that the above AdminOIDCConfigurationSettings bit from OIP is registered when using the setup-configuration management command
@alextreme alextreme added the enhancement New feature or request label Jul 8, 2024
@sergei-maertens
Copy link
Member

Feel free to take a look at https://github.com/maykinmedia/django-digid-eherkenning which has a similar setup with the optional [oidc] dependency group, especially with how tests are organized!

@Coperh Coperh moved this from Todo to In Progress in Data en API fundament Jul 9, 2024
@Coperh Coperh mentioned this issue Jul 10, 2024
Merged
Coperh added a commit that referenced this issue Jul 10, 2024
@Coperh
🚧[#114] add optional setup config
98b9b43
Coperh added a commit that referenced this issue Jul 10, 2024
@Coperh
🚧[#114] add optional setup config
df9ec47
Coperh added a commit that referenced this issue Jul 10, 2024
@Coperh
🚧[#114] add optional setup config
affedac
Coperh added a commit that referenced this issue Jul 10, 2024
@Coperh
👷[#114] update CI for setup config
ed93d42
Coperh added a commit that referenced this issue Jul 10, 2024
@Coperh
✨[#114] add optional setup config support
ed6c3b0
Coperh added a commit that referenced this issue Jul 10, 2024
@Coperh
✨[#114] add optional setup config support
fc242eb
Coperh added a commit that referenced this issue Jul 10, 2024
@Coperh
✨[#114] add optional setup config support
c9f80ed
Coperh added a commit that referenced this issue Jul 10, 2024
@Coperh
♻️[#114] move setup config to bootstrap directory
1b37fe3
Coperh added a commit that referenced this issue Jul 26, 2024
@Coperh
📝[#114] add documentation
25242d9
Coperh added a commit that referenced this issue Jul 26, 2024
@Coperh
📝[#114] add documentation
c60c2e3
Coperh added a commit that referenced this issue Jul 26, 2024
@Coperh
📝[#114] add documentation
6a447fc
Coperh added a commit that referenced this issue Jul 30, 2024
@Coperh
♻️[#114] refactor setup configuraiton directory
6e001b1
@joeribekker joeribekker mentioned this issue Jul 30, 2024
Closed
6 tasks
Coperh added a commit that referenced this issue Jul 30, 2024
@Coperh
✨[#114] add optional setup config support
0303a1d
Coperh added a commit that referenced this issue Jul 30, 2024
@Coperh
📝[#114] add documentation
aca7802
Coperh added a commit that referenced this issue Jul 30, 2024
@Coperh
🐛[#114] make endpoints required
20f406b
@Coperh Coperh moved this from In Progress to Implemented in Data en API fundament Jul 31, 2024
Coperh added a commit that referenced this issue Aug 2, 2024
@Coperh
🐛[#114] make endpoints required
aca9492
@Coperh Coperh moved this from Implemented to In Progress in Data en API fundament Aug 6, 2024
Coperh added a commit that referenced this issue Aug 13, 2024
@Coperh
✨[#114] combine settings into single setting
6d1e6df
Coperh added a commit that referenced this issue Aug 13, 2024
@Coperh
✨[#114] combine settings into single setting
76ccc85
Coperh added a commit that referenced this issue Aug 14, 2024
@Coperh
👷[#114] update CI
cd68db8
Coperh added a commit that referenced this issue Nov 22, 2024
@Coperh
💚[#114] update CI for setup configuration
7c36896
Coperh added a commit that referenced this issue Nov 22, 2024
@Coperh
📝[#114] add setup configuration documentation
6db9491
Coperh added a commit that referenced this issue Nov 22, 2024
@Coperh
♻️[#114] refactor AdminOIDCConfigurationStep
c09cf9d
Coperh added a commit that referenced this issue Nov 22, 2024
@Coperh
✨[#114] add setup configuration
5715b80 
* Add setup configuraiton model and step
* Add OIDCSetupConfigForm with only required fields
* Create common create_missing_groups util
Coperh added a commit that referenced this issue Nov 22, 2024
@Coperh
✅[#114] add setup configuration tests
a63657e
Coperh added a commit that referenced this issue Nov 22, 2024
@Coperh
💚[#114] update CI for setup configuration
71ddd88
Coperh added a commit that referenced this issue Nov 22, 2024
@Coperh
📝[#114] add setup configuration documentation
25feb25
Coperh added a commit that referenced this issue Nov 22, 2024
@Coperh
📝[#114] update setup config docs
08b8d76
Coperh added a commit that referenced this issue Nov 22, 2024
@Coperh
📝[#114] update setup config docs
14b6abd
Coperh added a commit that referenced this issue Nov 25, 2024
@Coperh
📝[#114] update setup config docs
56e3855
Coperh added a commit that referenced this issue Nov 25, 2024
@Coperh
📝[#114] update setup config docs
dfbfe29
Coperh added a commit that referenced this issue Nov 27, 2024
@Coperh
♻️[#114] make config key names lowercase
dead144
Coperh added a commit that referenced this issue Nov 27, 2024
@Coperh
♻️[#114] make config key names lowercase
a3d7e8b
Coperh added a commit that referenced this issue Nov 27, 2024
@Coperh
♻️[#114] make config key names lowercase
49d035c
Coperh added a commit that referenced this issue Nov 29, 2024
@Coperh @swrichards
📝[#114] Apply documentation suggestions from code review
9679244 
Co-authored-by: Sidney Richards <[email protected]>
Coperh added a commit that referenced this issue Nov 29, 2024
@Coperh
♻️[#114] streamline configuration step and model
623d37d 
* Pin django-setup-configuration >= 0.4.0
* Use Pydantic model defaults, remove defaults from step
* Remove now unneeded OIDCSetupConfigForm
* Set non-default values for test_configure_use_defaults
* Update Documentation
Coperh added a commit that referenced this issue Nov 29, 2024
@Coperh
♻️[#114] streamline configuration step and model
1d0bdbf 
* Pin django-setup-configuration >= 0.4.0
* Use Pydantic model defaults, remove defaults from step
* Remove now unneeded OIDCSetupConfigForm
* Set non-default values for test_configure_use_defaults
* Update Documentation
Coperh added a commit that referenced this issue Nov 29, 2024
@Coperh
♻️[#114] streamline setup config tests
da8600b 
* Set non default values in model in test_configure_use_defaults
* Remove model fixtures in favour of file yml fixtures
* Move from build_step_config_from_sources in fixture to execute_single_step in test
* Remove model validaiton tests
Coperh added a commit that referenced this issue Nov 29, 2024
@Coperh
📝[#114] add setup configuration command example to documentation
d8ac68e
Coperh added a commit that referenced this issue Dec 2, 2024
@Coperh
♻️[#114] implement suggested changes
2321306
Coperh added a commit that referenced this issue Dec 2, 2024
@Coperh
♻️[#114] implement suggested changes
d98dc5b
Coperh added a commit that referenced this issue Dec 2, 2024
@Coperh
📝[#114] make warning more clear
4e51bd9
@sjoerdie sjoerdie removed the blocked label Dec 2, 2024
Coperh added a commit that referenced this issue Dec 2, 2024
@Coperh
♻️[#114] implement suggested changes
f0f4623
Coperh added a commit that referenced this issue Dec 2, 2024
@Coperh
📝[#114] make warning more clear
ecad85b
Coperh added a commit that referenced this issue Dec 2, 2024
@Coperh
♻️[#114] rename dependency group
ee32542
Coperh added a commit that referenced this issue Dec 2, 2024
@Coperh
♻️[#114] refactor setup configuration step
a2c8e7d 
* Explicitly use model values
* Rename create_missing_groups to get_groups_by_name
* Move sync_groups condition to get_groups_by_name
* Fix sync_group doing nothing in step
* Test sync_group & sync_groups_glob_pattern
* Test idempotent and overwrite
Coperh added a commit that referenced this issue Dec 2, 2024
@Coperh
♻️[#114] refactor setup configuration step
d6c8846 
* Explicitly use model values
* Rename create_missing_groups to get_groups_by_name
* Move sync_groups condition to get_groups_by_name
* Fix sync_group doing nothing in step
* Test sync_group & sync_groups_glob_pattern
* Test idempotent and overwrite
@github-project-automation github-project-automation bot moved this from Implemented to Done in Data en API fundament Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swrichards swrichards

@Coperh Coperh

@stevenbal stevenbal

Labels
enhancement New feature or request owner: dimpact
Projects
Data en API fundament
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/114 add django setup configuration maykinmedia/mozilla-django-oidc-db
7 participants
@joeribekker @alextreme @swrichards @Coperh @sergei-maertens @stevenbal @sjoerdie