Refactor core API based on Pydantic models and direct loading from external sources #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swrichards
force-pushed
the
swr/pydantic-based-setup
branch
2 times, most recently
from
aceca0d to
d594a46
Compare
|
@stevenbal This is not quite done, I need to do another pass for docstrings, some naming issues, and so on, but if you have a moment this week, it would be great to get a high level sign-off on the basic approach here before I publish it. |
stevenbal
requested changes
Nov 15, 2024
django_setup_configuration/management/commands/setup_configuration.py
Outdated
Show resolved
Hide resolved
Merged
9 tasks
stevenbal
reviewed
Nov 19, 2024
swrichards
force-pushed
the
swr/pydantic-based-setup
branch
16 times, most recently
from
11d2dc2 to
46eccfa
Compare
swrichards
force-pushed
the
swr/pydantic-based-setup
branch
4 times, most recently
from
2da8c93 to
c7e38cb
Compare
stevenbal
approved these changes
Nov 21, 2024
|
Looks good to me! Like you mentioned, the naming issues can be tackled in a separate PR |
swrichards
force-pushed
the
swr/pydantic-based-setup
branch
5 times, most recently
from
6f219b8 to
c894d95
Compare
swrichards
force-pushed
the
swr/pydantic-based-setup
branch
3 times, most recently
from
881410d to
fb9bf86
Compare
stevenbal
reviewed
Nov 25, 2024
swrichards
force-pushed
the
swr/pydantic-based-setup
branch
from
fb9bf86 to
eed63d1
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussions related both to PodiumD integration and broader lessons learned with regards to configuration management, this PR implements the first (big) iteration on the new design: step configs are loaded directly from external sources and are fully typed and validated using Pydantic.
This PR has removed two hooks from the API (the configuration check, and the self test), not because they are not important, but because such "liveness" and "health" checks arguably belong elsewhere. Documentation generation and multi-file yaml sources will be implemented in an upcoming iteration.