zsh: rename option syntax-highlighting

[WilliButz]

rename zsh-option "syntax-highlighting" -> "syntaxHighlighting"

Motivation for this change

Things done

• Tested using sandboxing
  (nix.useSandbox on NixOS,
  or option build-use-sandbox in nix.conf
  on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • Linux
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

---

[Ma27]

you have to update the programs.zsh.syntax-highlighting.patterns option as well...

[WilliButz]

I obviously missed that 👍

[Ma27]

as I'm the author of this module: do we have any consistent style guide which describes the notation of module names? I've seen several modules in the module-list using dash and underscore notation, so it seems as camelCase is not the only thing in use.

[WilliButz]

@Ma27 I don't know of any consistent style guide. My intention was to make the zsh options more similar.
Most of them are enableSomeOption and I thought why is not enableSyntaxHighlighting.

When I saw that there are more syntax-related options than just enable, I renamed it to something as close to the others as possible. :)

[fpletz]

I didn't find any documentation on the case of NixOS option names but most core options (not regarding services/programs) seem to be camel-case.

[fpletz]

@Ma27 If that's okay with you, I would merge this and push to upstream.

[groxxda]

http://nixos.org/nixpkgs/manual/#sec-syntax :

Use lowerCamelCase for variable names [...]

[Ma27]

@groxxda thanks for pointing that out.

@fpletz @WilliButz I'm fine with that. When I built that some weeks ago I was unsure which notation to take, so I decided to stay consistent with the package name.
However please keep in mind that oh-my-zsh might be renamed to ohMyZsh as well in that case.

[Ma27]

btw is it planned to merge this change back to upstream? Just asking because this is yet another diverge from upstream, but not that controversial IMHO.

[WilliButz]

I'd like to see it upstream as well but it's not up to me to make this decision :)

[fpletz]

Pushed upstream: NixOS@4e4f7a2