Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify setup using Docker Compose #599

Closed
wants to merge 1 commit into from

Conversation

Quintasan
Copy link

This is a barebones configuration for Docker Compose.

  1. docker compose build
  2. docker compose up -d

Application will be available on http://localhost:3000.

Actual production deployments will require a reverse proxy in front of the app container.

@zachgoll
Copy link
Collaborator

zachgoll commented Apr 3, 2024

@Quintasan the ENV changes and sample file make sense here, but could you explain the overall usage of this in a bit more detail? I'll be doing a bunch of work this week around Docker and self-hosting, so just want to make sure I understand the purpose here.

I'm guessing this is mainly a setup that allows self-hosters to specify their own custom Docker compose configs?

@Quintasan
Copy link
Author

@Quintasan the ENV changes and sample file make sense here, but could you explain the overall usage of this in a bit more detail? I'll be doing a bunch of work this week around Docker and self-hosting, so just want to make sure I understand the purpose here.

I'm guessing this is mainly a setup that allows self-hosters to specify their own custom Docker compose configs?

@zachgoll The intent here is to have a minimal hassle, non-opinionated way to deploy Maybe using Docker Compose. We could make it the default (because right now you have to cp compose.example.yml compose.yml) and instruct users that they can use compose.override.yml to change any setting they don't like, since it's sourced by Docker Compose if present.

@zachgoll
Copy link
Collaborator

zachgoll commented Apr 4, 2024

@Quintasan gotcha, so you're looking to self-host on a VPS and use a docker-compose pull && docker-compose up workflow for keeping it on the latest release, correct?

@Quintasan
Copy link
Author

@Quintasan gotcha, so you're looking to self-host on a VPS and use a docker-compose pull && docker-compose up workflow for keeping it on the latest release, correct?

Ideally yes, but since you don't actually publish an image anywhere you need to docker compose build before.

@zachgoll
Copy link
Collaborator

zachgoll commented Apr 4, 2024

@Quintasan got it, I'm thinking we'll want to provide an opinionated compose file in source control along with publishing an official image on each release per #295. I've got a bit of local work around this right now, so I think at this moment if we could pare this PR down to just the ENV cleanup that would be great. I'll have a PR opened this week for the deployment scenario you're describing, so if you have specific requirements that you'd be looking for, let me know.

@Quintasan
Copy link
Author

@Quintasan got it, I'm thinking we'll want to provide an opinionated compose file in source control along with publishing an official image on each release per #295. I've got a bit of local work around this right now, so I think at this moment if we could pare this PR down to just the ENV cleanup that would be great. I'll have a PR opened this week for the deployment scenario you're describing, so if you have specific requirements that you'd be looking for, let me know.

@zachgoll Makes sense. If you're willing to push up your changes up to a visible branch then I'd be happy to collaborate on the compose file

@zachgoll
Copy link
Collaborator

zachgoll commented Apr 4, 2024

@Quintasan sounds great, hoping to get something opened in the next day or two.

@zachgoll
Copy link
Collaborator

@Quintasan okay so we now have a much clearer path for Docker and self-hosting. I've opened up #627 with detailed requirements and to act as a centralized collaboration spot.

@zachgoll zachgoll closed this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants